Questions for docs, part 3

[Gervase Markham]

* Does anyone still use Patch Viewer?
- It only works with CVS.
- It requires a Perl module not on CPAN.
- BMO doesn't seem to use it any more.
- We already have Splinter.
- We are moving in the direction of Review Board integration.

Can we tear out the docs (and the code)?

Gerv
_______________________________________________
dev-apps-bugzilla mailing list
dev-apps-bugzilla-CzyLcWPZiU5YsZ3hbOqMTti2O/***@public.gmane.org
https://lists.mozilla.org/listinfo/dev-apps-bugzilla
-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+***@public.gmane.org>

[Frédéric Buclin]

Post by Gervase Markham
* Does anyone still use Patch Viewer?

I do. That's how I review patches.

Post by Gervase Markham
- It only works with CVS.

Only half true. It works with bzr, git, etc... What only works with CVS
is the "# lines for context" feature.

Post by Gervase Markham
- It requires a Perl module not on CPAN.

No idea which module you are talking about. Linux distros have
PatchReader available and it's working fine.

Post by Gervase Markham
- BMO doesn't seem to use it any more.
- We already have Splinter.
- We are moving in the direction of Review Board integration.

What do they require as dependencies or configuration?

Post by Gervase Markham
Can we tear out the docs (and the code)?

No reason for now. It currently has no replacement implemented upstream.


LpSolit

-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+***@public.gmane.org>

[David Lawrence]

Post by Frédéric Buclin

Post by Gervase Markham
- BMO doesn't seem to use it any more.
- We already have Splinter.
- We are moving in the direction of Review Board integration.

What do they require as dependencies or configuration?

Splinter does not have any dependencies on its own (YUI2?) as it is pure
javascript but it is an extension and is not part of the upstream Bugzilla
code and likely will never be.

Reviewboard is the direction *Mozilla* is moving for code review and there
is work to integrate it would BMO specifically using extensions and the
webservice API. So another solution that will likely not be part of the
upstream as it is a fully third party code review tool.

Post by Frédéric Buclin

Post by Gervase Markham
Can we tear out the docs (and the code)?

No reason for now. It currently has no replacement implemented upstream.

I agree as we. Upstream Bugzilla itself needs to have some sort of native
patch viewer built in and PatchReader is the best thing for now. People are
still able to install whatever add-ons they want be it Splinter, Reviewboard
or something else.

dkl

[Gervase Markham]

Post by Frédéric Buclin

Post by Gervase Markham
Can we tear out the docs (and the code)?

No reason for now. It currently has no replacement implemented upstream.

OK, fair enough. Question answered :-) But perhaps we should make it
more clear somewhere that you don't need CVS, Bonsai and LXR for it to
be useful.

Gerv

-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+***@public.gmane.org>

[Frédéric Buclin]

Post by Gervase Markham
OK, fair enough. Question answered :-) But perhaps we should make it
more clear somewhere that you don't need CVS, Bonsai and LXR for it to
be useful.

Or simply remove CVS-specific code (I really mean code here, not doc
only). That's something I wouldn't be opposed to, and would let us kill
the "Patch Viewer" panel in the Parameters page completely. CVS is
probably not so common nowadays, and I'm not sure anyone is still using
Bonsai or LXR these days.

LpSolit

-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+***@public.gmane.org>

[Gervase Markham]

Post by Frédéric Buclin
Or simply remove CVS-specific code (I really mean code here, not doc
only). That's something I wouldn't be opposed to, and would let us kill
the "Patch Viewer" panel in the Parameters page completely. CVS is
probably not so common nowadays, and I'm not sure anyone is still using
Bonsai or LXR these days.

That's a good idea. Bug filed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1068494

Gerv

_______________________________________________
dev-apps-bugzilla mailing list
dev-apps-***@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-apps-bugzilla
-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=$MSG

[Andre Klapper]

Post by Gervase Markham
* Does anyone still use Patch Viewer?

Wasn't survey-***@public.gmane.org meant to be a list to reach out to Bugzilla
administrators out there?
Sounds like the potential audience to me ("If anyone still uses 'Patch
Viewer', please speak up within the next 14 days or it'll be removed").

andre
--
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/

_______________________________________________
dev-apps-bugzilla mailing list
dev-apps-bugzilla-CzyLcWPZiU5YsZ3hbOqMTti2O/***@public.gmane.org
https://lists.mozilla.org/listinfo/dev-apps-bugzilla
-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+***@public.gmane.org>

[Frédéric Buclin]

Post by Andre Klapper
administrators out there?
Sounds like the potential audience to me
("If anyone still uses 'Patch
Viewer', please speak up within the next 14 days or it'll be removed").

14 days would certainly be too short. There is no hurry to remove this
feature. It's not broken, has no security vulnerability, and it's not
like this feature prevents you from writing new features. If gerv wants
to kill something, I will point him to Old Charts first.

LpSolit

-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+***@public.gmane.org>